Repository navigation
Bump the k8sio group across 1 directory with 4 updates - #303
dependabot[bot] wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| k8s.io/cli-runtime/pkg/printers | ||
| k8s.io/cli-runtime/pkg/resource | ||
| # k8s.io/client-go v0.37.1 | ||
| # k8s.io/client-go v0.37.2 |
There was a problem hiding this comment.
🟡 Vendored Kubernetes code remains on old patch
The v0.37.2 module entries still point builds at unchanged v0.37.1 vendored sources. Released binaries therefore omit the Kubernetes patch updates.
Learn more
Go uses vendor/ by default for this module, so changing go.mod and modules.txt alone does not replace the source compiled into the binaries. None of the vendored Kubernetes source files changed in this PR. The version labels now describe a newer release than the code they accompany.
Example: A release built from this PR records k8s.io/client-go v0.37.2 in module metadata, but compiles the unchanged client-go files vendored before the bump.
Recommended fix: Run go mod vendor with the updated module versions and commit the resulting changes under vendor/k8s.io/; verify that make check-vendor produces no diff.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
This is incorrect. "go mod vendor" produces no more diff.
|
/ok to test a9f1d3e |
Coverage Report for CI Build 43554142458Coverage remained the same at 24.026%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
rahulait
left a comment
rahulait
left a comment
There was a problem hiding this comment.
needs manual updates to fix vendored modules as they are not correctly added.
dependabot
Bot
changed the title
815248b to
3211f35
Compare
|
@dependabot rebase |
3211f35 to
c09c02e
Compare
Bumps the k8sio group with 4 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery), [k8s.io/client-go](https://github.com/kubernetes/client-go) and [k8s.io/kubectl](https://github.com/kubernetes/kubectl). Updates `k8s.io/api` from 0.37.1 to 0.37.2 - [Commits](kubernetes/api@v0.37.1...v0.37.2) Updates `k8s.io/apimachinery` from 0.37.1 to 0.37.2 - [Commits](kubernetes/apimachinery@v0.37.1...v0.37.2) Updates `k8s.io/client-go` from 0.37.1 to 0.37.2 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.37.1...v0.37.2) Updates `k8s.io/kubectl` from 0.37.1 to 0.37.2 - [Commits](kubernetes/kubectl@v0.37.1...v0.37.2) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.37.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8sio - dependency-name: k8s.io/apimachinery dependency-version: 0.37.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8sio - dependency-name: k8s.io/client-go dependency-version: 0.37.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8sio - dependency-name: k8s.io/kubectl dependency-version: 0.37.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8sio ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
c09c02e to
ac6070d
Compare
|
/ok to test ac6070d |
Bumps the k8sio group with 4 updates in the / directory: k8s.io/api, k8s.io/apimachinery, k8s.io/client-go and k8s.io/kubectl.
Updates
k8s.io/apifrom 0.37.1 to 0.37.2Commits
1bc0c52Update dependencies to v0.37.2 tagUpdates
k8s.io/apimachineryfrom 0.37.1 to 0.37.2Commits
97adf14Update dependencies to v0.37.2 tagUpdates
k8s.io/client-gofrom 0.37.1 to 0.37.2Commits
72c52ddUpdate dependencies to v0.37.2 tagUpdates
k8s.io/kubectlfrom 0.37.1 to 0.37.2Commits
b6fd715Update dependencies to v0.37.2 tag